Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use vite@5 #353

Merged
merged 6 commits into from
Dec 20, 2024
Merged

fix: use vite@5 #353

merged 6 commits into from
Dec 20, 2024

Conversation

manuel3108
Copy link
Member

Relates #341, #311 (comment)

From vitest-dev/vitest#7014 (comment)

Vitest 2 doesn't support Vite 6 and will not support Vite 6 officially. You can use resolutions or pnpm.overrides to change the version range locally, Vite 6 API is the same and should work for Vitest 2.

If you migrated to Vite 6, use Vitest 3 (currently in beta), release is planned for January.

If you see any type errors in your config, check the lockfile to confirm that you have several Vite versions installed and resolve it with your package manager.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 11, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 1b20b38

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Dec 11, 2024 •
edited
Loading

Open in Stackblitz

npm i https://pkg.pr.new/sveltejs/cli/sv@353

npm i https://pkg.pr.new/sveltejs/cli/svelte-migrate@353

commit: 1b20b38

@dominikg dominikg mentioned this pull request Dec 14, 2024
Closed
AdrianGonz97
AdrianGonz97 requested changes Dec 16, 2024
View reviewed changes
packages/create/templates/demo/package.json Outdated Show resolved Hide resolved
packages/create/templates/demo/package.template.json Outdated Show resolved Hide resolved
packages/create/templates/library/package.template.json Outdated Show resolved Hide resolved
packages/create/templates/minimal/package.template.json Outdated Show resolved Hide resolved
@dominikg
Copy link
Member

whats missing to get this merged?

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-cli-353-svelte.vercel.app/

this is an automated message

@AdrianGonz97 AdrianGonz97 merged commit a2dceba into main Dec 20, 2024
8 checks passed
@AdrianGonz97 AdrianGonz97 deleted the fix/use-vite-5 branch December 20, 2024 18:15
@github-actions github-actions bot mentioned this pull request Dec 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdrianGonz97 AdrianGonz97 AdrianGonz97 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@manuel3108 @dominikg @Rich-Harris @AdrianGonz97